Stop falling back to old_ems_id #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ems_id always set since we switched to soft delete. Backfilled for old records too by ManageIQ/manageiq-schema#18.
|
Checked commit cben@6722278 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@agrare please review, I shouldn't merge my own PRs. |
agrare
approved these changes
Jul 6, 2018
|
Nice cleanup @cben |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@miq-bot add-label technical debt
A step towards #196.
ems_idis always set since we switched to soft delete.ems_idgot backfilled fromold_ems_idfor old disconnected records too by ManageIQ/manageiq-schema#18.@zeari @Ladas please review